[FEAT] improved rendering for exclusive gateway #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aibcmars
added
the
depends on another PR ⚠️
Contributor
Author
|
Depends on #222 |
aibcmars
changed the title
tbouffard
added
the
rebase needed 💥
aibcmars
removed
the
rebase needed 💥
aibcmars
force-pushed
the
197_improved_scaleFactorCanvas
branch
from
7fe7277 to
bc69a6d
Compare
aibcmars
removed
the
depends on another PR ⚠️
csouchet
reviewed
May 6, 2020
aibcmars
force-pushed
the
197_improved_scaleFactorCanvas
branch
from
bc69a6d to
aec30da
Compare
Member
tbouffard
approved these changes
May 6, 2020
Member
There was a problem hiding this comment.
LGTM
However, some refactoring as needed IMHO because this PR doesn't fully covered what I had in mind with #222 (comment)
- scaling is still explicitly present in code outside of the canvas wrapper
- it is not possible to scale on x and y with different values
- translation is done globally which leads to side effects
So, I have create a new issue to track this missing technical requirement, see #247
|
|
||
| c.fillAndStroke(); | ||
| const canvas = this.configureCanvasForIcon(c, w, h, 0); | ||
| this.translateToStartingIconPosition(c, x, y, w, h); |
Member
There was a problem hiding this comment.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code mutualization