Skip to content

[FEAT] Render Exclusive Gateway #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tbouffard merged 6 commits into from
Apr 28, 2020
Merged

[FEAT] Render Exclusive Gateway #209

tbouffard merged 6 commits into from
Apr 28, 2020

Conversation

@aibcmars
Copy link
Contributor

@aibcmars aibcmars commented Apr 22, 2020

Closes #197

@tbouffard tbouffard added BPMN rendering Something about the way the lib is rendering BPMN elements enhancement New feature or request labels Apr 22, 2020
csouchet
csouchet reviewed Apr 22, 2020
View reviewed changes
tbouffard
tbouffard reviewed Apr 22, 2020
View reviewed changes
tbouffard
tbouffard reviewed Apr 22, 2020
View reviewed changes
@tbouffard tbouffard added the rebase needed 💥 Pull request that must be rebased on the latest master commit prior being reviewed or merged label Apr 22, 2020
@aibcmars aibcmars force-pushed the 197_render_exclusive_gateway branch from 8338857 to cd631e2 Compare April 28, 2020 12:09
@aibcmars aibcmars removed the rebase needed 💥 Pull request that must be rebased on the latest master commit prior being reviewed or merged label Apr 28, 2020
tbouffard
tbouffard reviewed Apr 28, 2020
View reviewed changes
@tbouffard
Copy link
Member

tbouffard commented Apr 28, 2020

Without exclusive gateway rendering

01_without_exclusive_gateway_rendering

With exclusive gateway rendering

02_with_exclusive_gateway_rendering

tbouffard
tbouffard approved these changes Apr 28, 2020
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice job

@tbouffard tbouffard merged commit d021528 into master Apr 28, 2020
@tbouffard tbouffard deleted the 197_render_exclusive_gateway branch April 28, 2020 13:23
@NathalieC
Copy link
Contributor

NathalieC commented Apr 28, 2020

LGTM!

@tbouffard tbouffard mentioned this pull request Apr 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tbouffard tbouffard tbouffard approved these changes

+1 more reviewer

@csouchet csouchet csouchet left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

BPMN rendering Something about the way the lib is rendering BPMN elements enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEAT] Render Exclusive gateway

5 participants

@aibcmars @tbouffard @NathalieC @csouchet