[INFRA] Improve surge preview workflows #2072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbouffard
added
chore
|
♻️ PR Preview f8d8ae8 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
♻️ PR Preview f8d8ae8 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
tbouffard
changed the title
tbouffard
removed
the
WIP 🚧
csouchet
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove duplication by introducing a custom action. We now run a single job instead of 2 jobs with cryptic secret checks.
Delegate most of the work to the https://github.com/bonitasoft/actions
surge-preview-toolsaction to better manage PR created from fork repositories or by Dependabot.We shouldn't have error on PR close when it was created by dependabot: most of the time the preview doesn't exist. We previously had errors because we always tried to teardown the surge domain even when it didn't exist. This is now fixed.
Previously valided with process-analytics/github-actions-playground#103