[FEAT] Render Task #207
Merged
[FEAT] Render Task #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csouchet
added
enhancement
csouchet
force-pushed
the
142-Render_Task
branch
from
9a4f830 to
a1417c2
Compare
Contributor
Author
|
The render: |
tbouffard
reviewed
Apr 22, 2020
| constructor(private graph: mxgraph.mxGraph) {} | ||
|
|
||
| public configureStyles(): void { | ||
| this.mxConstants.RECTANGLE_ROUNDING_FACTOR = 0.1; |
| private configureTaskStyle(): void { | ||
| const style = this.mxUtils.clone(this.getStylesheet().getCellStyle(ShapeBpmnElementKind.TASK_USER), this.getDefaultVertexStyle()); | ||
| style[this.mxConstants.STYLE_STROKECOLOR] = '#663399'; | ||
| const style = this.cloneDefaultVertexStyle(); |
Member
There was a problem hiding this comment.
❓ I guess we will generalize styling for other tasks when implementing rendering for user or service task
Contributor
Author
There was a problem hiding this comment.
Yes, I started the refactoring in the Service Task's PR #208 😉
tbouffard
approved these changes
Apr 22, 2020
Member
tbouffard
left a comment
tbouffard
left a comment
There was a problem hiding this comment.
LGTM 👍
Here is the rendering of the A.1.0 bpmn reference file
Version 0.1.2
With new implementation
Co-Authored-By: Thomas Bouffard <[email protected]>
Member
|
|
Contributor
Author
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #142