Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for query string forwarding #100

Merged
merged 7 commits into from
Mar 31, 2019
Merged

add support for query string forwarding #100

merged 7 commits into from
Mar 31, 2019

Conversation

rpetti
Copy link
Contributor

@rpetti rpetti commented Feb 2, 2019

Proposed solution for #98

tcbyrd
tcbyrd requested changes Feb 7, 2019
View reviewed changes
Copy link
Contributor

@tcbyrd tcbyrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rpetti! Thanks for opening this PR. A few minor suggestions around code style, but also would you mind adding a test for this? Definitely on board with the concept.

client/index.js Outdated Show resolved Hide resolved
client/index.js Outdated Show resolved Hide resolved
client/index.js Outdated Show resolved Hide resolved
@rpetti
Copy link
Contributor Author

rpetti commented Feb 7, 2019

Thanks @tcbyrd! I've made your recommended changes and added a test. Please let me know if more adjustments are necessary; I'm fairly new at Node.

@dhs-rec
Copy link

dhs-rec commented Mar 20, 2019

Seems to be stuck for more than a month now...

JasonEtco
JasonEtco requested changes Mar 31, 2019
View reviewed changes
Copy link
Member

@JasonEtco JasonEtco left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rpetti 🙏 I left two little notes, but otherwise this is looking great ✨

client/index.js Outdated Show resolved Hide resolved
client/index.js Outdated Show resolved Hide resolved
JasonEtco and others added 2 commits March 30, 2019 21:48
@rpetti
Copy link
Contributor Author

rpetti commented Mar 31, 2019

Thanks for the suggestions @JasonEtco! I've committed them. 😁

JasonEtco
JasonEtco approved these changes Mar 31, 2019
View reviewed changes
Copy link
Member

@JasonEtco JasonEtco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick adjustment @rpetti! And I appreciate your patience 🙏 I'll go ahead and merge 🎉 I'll also publish this as v1.1.0.

@JasonEtco JasonEtco merged commit c010e11 into probot:master Mar 31, 2019
@JasonEtco JasonEtco mentioned this pull request Mar 31, 2019
Closed
Uzlopak pushed a commit to Uzlopak/smee-client that referenced this pull request Nov 19, 2023
@JasonEtco
Merge pull request probot#100 from rpetti/query-strings-forwarding
3f90f40 
add support for query string forwarding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcbyrd tcbyrd tcbyrd requested changes

@JasonEtco JasonEtco JasonEtco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rpetti @dhs-rec @JasonEtco @tcbyrd