Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update build targets #308

Merged
merged 15 commits into from
Aug 29, 2024
Merged

chore: update build targets #308

merged 15 commits into from
Aug 29, 2024

Conversation

Uzlopak
Copy link

@Uzlopak Uzlopak commented Aug 29, 2024

No description provided.

@Uzlopak
Copy link
Author

Uzlopak commented Aug 29, 2024

@wolfy1339

should we target a beta branch?

@wolfy1339
Copy link
Contributor

Do we want to push other breaking changes? Or changes that can only happen with this PR merged?

@Uzlopak
Copy link
Author

Uzlopak commented Aug 29, 2024

We gonna break things for esm only

@wolfy1339
Copy link
Contributor

I'd say yes let's target a beta branch

@Uzlopak Uzlopak changed the base branch from main to beta August 29, 2024 13:31
@Uzlopak
Copy link
Author

Uzlopak commented Aug 29, 2024

@wolfy1339

PTAL

@Uzlopak Uzlopak requested a review from wolfy1339 August 29, 2024 13:31
@wolfy1339
Copy link
Contributor

Update the package.json engines field as well

@Uzlopak
Copy link
Author

Uzlopak commented Aug 29, 2024

@wolfy1339
done ;). also modified the ci.yml

.github/workflows/test.yml Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
@Uzlopak
Copy link
Author

Uzlopak commented Aug 29, 2024

It broke now...i am now on the way home. Any idea?

@wolfy1339 wolfy1339 merged commit 78289c0 into beta Aug 29, 2024
15 of 16 checks passed
@wolfy1339 wolfy1339 deleted the ci branch August 29, 2024 16:36
Copy link

🎉 This issue has been resolved in version 3.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants