This repository was archived by the owner on Jul 14, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IIUC, the
logits
argument forjax.random.categorical
correspond to log probabilities instead of their logit values(defined by log(p/(1-p))),
and so the usage of
jax.random.categorical
inhmm_forwards_filtering_backwards_sampling_jax
andhmm_sample_jax
should be modified to take injnp.log(.)
instead oflogit(.)
.From the documentation for
jax.random.catgegorical
: