Fix else transformation to use all old variables #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the following program:
The else branch should be dead code. However, its inclusion causes the analysis to change from
E(x) = 0; 2 - 2/2**n
to the incorrect resultE(x) = 0; 3 - 3/2**n
. This happens because the else transformation does not replacec
with the variable storing its old value in the transformed else condition!(c == 1)
.This PR makes the appropriate fix and adds the above example as a regression test.