Fix clippy lints #23
Merged
Fix clippy lints #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djmattyg007
reviewed
Jul 14, 2021
|
@probablykasper Can you perform a squash merge from your site or should I make a new PR with a single commit? |
|
Yeah, sure |
probablykasper
approved these changes
Aug 16, 2021
|
Forgot to squash merge, oh well 🤦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed every clippy lint (except for the "this if has identical blocks" lint, because it would break the current structure). The fixes are separated in three commits to give it a better structure.