Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adjust feature detection for node 18.19 loader changes #422

Merged
merged 3 commits into from
Nov 30, 2023
Merged

fix: adjust feature detection for node 18.19 loader changes #422

merged 3 commits into from
Nov 30, 2023

Conversation

brc-dd
Copy link
Contributor

@brc-dd brc-dd commented Nov 30, 2023

fixes #421

@brc-dd brc-dd marked this pull request as draft November 30, 2023 01:35
@brc-dd brc-dd marked this pull request as ready for review November 30, 2023 01:37
@brc-dd brc-dd marked this pull request as draft November 30, 2023 01:55
@brc-dd brc-dd marked this pull request as ready for review November 30, 2023 01:58
@brc-dd brc-dd marked this pull request as draft November 30, 2023 02:01
@brc-dd brc-dd marked this pull request as ready for review November 30, 2023 02:01
@privatenumber
Copy link
Owner

Thank you @brc-dd! Perfect PR 🔥

@privatenumber privatenumber merged commit f4f19e0 into privatenumber:develop Nov 30, 2023
2 checks passed
@brc-dd brc-dd deleted the fix/node-18.19 branch November 30, 2023 02:08
@privatenumber
Copy link
Owner

🎉 This issue has been resolved in v4.6.1

If you appreciate this project, please consider supporting this project by sponsoring ❤️ 🙏

@auvred auvred mentioned this pull request Dec 9, 2023
Closed
@paulfouquet paulfouquet mentioned this pull request Dec 11, 2023
Merged
@ShadiestGoat ShadiestGoat mentioned this pull request Dec 12, 2023
Merged
@u5r0 u5r0 mentioned this pull request Dec 18, 2023
Closed
@rexfordessilfie rexfordessilfie mentioned this pull request Feb 14, 2024
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@privatenumber privatenumber privatenumber left review comments

Assignees
No one assigned
Labels
outdated released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tsx doesn't work on Node 18.19
2 participants
@brc-dd @privatenumber