ci: improve node caching

privatenumber · Nov 24, 2023 · 4534ef5 · 4534ef5
1 parent af1b911
commit 4534ef5
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -42,7 +42,7 @@ jobs:
 
     - name: Get Node.js cache directory
       shell: bash
-      run: echo "NVE_CACHE=$(node -e 'console.log(require("cachedir")("nve"))')" >> $GITHUB_ENV
+      run: echo "NVE_CACHE=$(node -p 'require("cachedir")("nve")')" >> $GITHUB_ENV
 
     - name: Cache Node.js versions
       uses: actions/cache@v3

diff --git a/tests/utils/node-versions.ts b/tests/utils/node-versions.ts
@@ -1,13 +1,20 @@
+/**
+ * The specific version is used in CI because of caching
+ * Only pull the latest major version in development
+ * and upgrade manually for CI when needed
+ */
+const latestMajor = (version: string) => (process.env.CI ? version : version.split('.')[0]);
+
 export const nodeVersions = [
-	'21',
+	latestMajor('21.2.0'),
 	...(
 		(
 			process.env.CI
 			&& process.platform !== 'win32'
 		)
 			? [
-				'20',
-				'18',
+				latestMajor('20.10.0'),
+				latestMajor('18.18.2'),
 				'18.0.0',
 			] as const
 			: [] as const