Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Add Riot Chat Client #613

Merged
21 commits merged into from
Dec 23, 2018
Merged

Add Riot Chat Client #613

21 commits merged into from
Dec 23, 2018

Conversation

asddsaz
Copy link
Contributor

@asddsaz asddsaz commented Nov 23, 2018

Fixes #597

@ghost
Copy link

ghost commented Nov 23, 2018

  • Add Wire to worth mentioning
  • Signal should be before Riot. Not to mention that the colors are wrong.

@ghost
Copy link

ghost commented Nov 23, 2018

Protocole should be protocol; Matrix is a name.

@asddsaz
Copy link
Contributor Author

asddsaz commented Nov 23, 2018

@Shifterovich fixed!

@ghost
Copy link

ghost commented Nov 23, 2018

You removed a link to Wire's website and added a link to Wire's Google Play page.

@asddsaz
Copy link
Contributor Author

asddsaz commented Nov 23, 2018

@Shifterovich I'm so sorry, it should be fixed now :)

@ghost
Copy link

ghost commented Dec 22, 2018

Maybe add a longer description?

@asddsaz
Copy link
Contributor Author

asddsaz commented Dec 22, 2018

This branch has conflicts that must be resolved

@asddsaz asddsaz closed this Dec 22, 2018
@Mikaela
Copy link
Contributor

Mikaela commented Dec 22, 2018

I think Riot should have experimental label like Brave, because it warns about E2EE being experimental and matrix-org/synapse#1287 .

@ghost
Copy link

ghost commented Dec 22, 2018

https://github.com/privacytoolsIO/privacytools.io/blob/master/index.html#L1280

Add this warning to the link to Wire in the worth mentioning section.

And I'll resolve the conflicts.

@ghost ghost reopened this Dec 22, 2018
@ghost
Copy link

ghost commented Dec 22, 2018

Make the warning similar to uTox's warning, but with a tooltip. Here's some sample code you can use for that:

<span class="badge badge-warning" data-toggle="tooltip" title="Brave is a good choice if you want to use a Chromium-based browser. But at this point in Brave's development&comma; it's not as good as Firefox with privacy addons.">experimental <i class="far fa-question-circle"></i>

@ghost
Copy link

ghost commented Dec 22, 2018

screenshot from 2018-12-22 20-23-58

@ghost ghost assigned Vincevrp Dec 22, 2018
@ghost
Copy link

ghost commented Dec 22, 2018

Sorry, didn't notice it when I was fixing the conflicts. I'll take a look at the issue you sent.

@Kcchouette
Copy link
Contributor

Can you remove the "successor of XMPP' part too please @Shifterovich @asddsaz

@ghost
Copy link

ghost commented Dec 22, 2018

Right, we should remove that and think of a longer description.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the description.

@ghost
Copy link

ghost commented Dec 22, 2018

@Mikaela Also the E2EE isn't enabled by default, right?

@Kcchouette
Copy link
Contributor

An example of description: "Riot.im is a client based on Matrix, a recent open protocol for real-time communication. A distributed chat client that offers E2E Encryption. It can bridge other communications via others protocols such as IRC too."

@Mikaela
Copy link
Contributor

Mikaela commented Dec 22, 2018

@Mikaela Also the E2EE isn't enabled by default, right?

That is the case, it's opt-in and only very few clients support it, mainly Riot. They say that there is no point in E2EEing public rooms, which I agree, and it would also prevent the bridges from working.

Can you remove the "successor of XMPP' part too please

In case this wasn't changed yet, I don't think anyone working with IRC(v3?) has called them as successor of IRC either.

@Mikaela
Copy link
Contributor

Mikaela commented Dec 22, 2018

Two other issues with Matrix or Riot coming to my mind:

  • everyone can see your Matrix ID, I don't know if that is a major issue though, but Disroot.org cites it as one reason for not liking them.
  • you cannot set the public device name before you login, so if your device is "John Doe's iPhone" (or ONEPLUS A3003), everyone can see that in your profile until you change it. Some other clients than Riot ask how to name the device.

@ghost
Copy link

ghost commented Dec 22, 2018

Now I'm thinking that if the E2EE is experimental, what's the basis for recommending Matrix?

@ghost ghost assigned ghost and unassigned Vincevrp Dec 22, 2018
@ghost ghost removed the request for review from privacytoolsIO December 22, 2018 20:25
@Mikaela
Copy link
Contributor

Mikaela commented Dec 22, 2018

In case anyone wishes, here are some sources on the experimentality:

  • All files and data transferred over Riot can be encrypted end-to-end (currently in beta), meaning no one can eavesdrop on conversations, including the service provider.

  • As of May 2017 Riot’s end-to-end encryption is technically in beta, but this is due to some residual stability bugs and missing usability features. Once these are resolved we plan to get the full implementation security assessed and out of beta. End-to-end encryption will then be turned on by default for private conversations.

The strings from Android, I imagine iOS has similar (I don't think I need to dig them?):

@ghost
Copy link

ghost commented Dec 22, 2018

From the first string file:

You should not yet trust it to secure data.

I think this necessarily implies "You should not yet recommend it anyone to trust it to secure data."

Maybe we should add a labels='warning:beta:The software is currently in beta and the website states "End-to-end encryption is in beta and may not be reliable. You should not yet trust it to secure data."'

@Mikaela
Copy link
Contributor

Mikaela commented Dec 22, 2018

Maybe we should add a labels='warning:beta:The software is currently in beta and the website states "End-to-end encryption is in beta and may not be reliable. You should not yet trust it to secure data."'

I agree otherwise, but as the string is from Android client and not findable from the website I would say:

labels='warning:beta:The software is currently in beta and the mobile client states "End-to-end encryption is in beta and may not be reliable. You should not yet trust it to secure data."'

I only changed website to mobile client from your suggestion and I ended up digging for the iOS strings just in case it would disagree, but there is at least one of the same:

@Kcchouette
Copy link
Contributor

You can add too that it's not e2e by default

@asddsaz
Copy link
Contributor Author

asddsaz commented Dec 23, 2018

Right, we should remove that and think of a longer description.

Done, I also added an experimental flag.

Now I'm thinking that if the E2EE is experimental, what's the basis for recommending Matrix?

For the time being Riot is really good for create chatrooms. Similar to Discord or Slack.
I am unaware that you can do this in any of the alternatives listed.

@Shifterovich

@ghost
Copy link

ghost commented Dec 23, 2018

Look at Brave in the source code, you can add the label using the code @Mikaela used in her comment.

@ghost
Copy link

ghost commented Dec 23, 2018

Not sure about chatrooms but Signal can do group chats.

@ghost ghost merged commit 3bfc16c into privacytools:master Dec 23, 2018
@johnstonesnow
Copy link

I just posted on a thread before realising it was merged with this one and closed. I will post my message here in case Infosec is reading:

"Infosec-Handbook said: "Signal requires an arbitrary phone number which you must control during the registration process. However, you don't have to use your own private cellphone number. You can use the Tor Browser to get a disposable phone number for registration, set a PIN and never need access to the phone number during normal operation."

Sorry for chipping into an old thread, but I am currently torn between Wire and Signal. Two things put me off SIgnal:

  1. Phone number needed (I read that you have to have permanent access to the number to keep Signal Desktop working (I only use desktop).
  2. Based in US

If I could remove downside "1", I might see SIgnal as a better option than Wire. Can you confirm if this is still true, that you don't need to use a permanently accessible phone number? If so, do you have a guide or link on how to sign up for Signal without using my own phone number?

Thanks for any help, oh and PS - Now it's 2019, if you have any other recommendations please say. I tried Tox chat and it's private, but buggy as hell and I can't get people to use it. Signal and Wire are possibles because they have decent features, run properly, and I can get people to use them. But which one? :)"

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants