Allow setting DNS records in seperate GCP project #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add var gcp_dns_zones_project_id to service level for seller and buyer modules
davidae
force-pushed
the
load-balancer-set-gcp-project
branch
from
9c54b7e to
69a65d7
Compare
mihnjong-l
requested review from
dankocoj-google
and removed request for
dankocoj-google
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
gcp_dns_zones_project_idto service level for seller and buyer modules to configure the resource"google_dns_record_set" "collector"The existing setup assumes that the GCP project used for B&A is also responsible managing DNS and domains, which isn't always the case.