This repository was archived by the owner on Jul 5, 2024. It is now read-only.
Add tables documentation#93
Merged
Merged
Conversation
ed255
force-pushed
the
feature/tables-doc
branch
from
f7058dd to
9ad68e5
Compare
han0110
approved these changes
Jan 18, 2022
Contributor
han0110
left a comment
han0110
left a comment
There was a problem hiding this comment.
LGTM! Thanks for documenting all of these!
| | Time | 0 | $value | | ||
| | Difficulty | 0 | $value | | ||
| | BaseFee | 0 | $value | | ||
| | BlockHash | 0..256 | $value | |
Contributor
There was a problem hiding this comment.
This is currently implemented as the actual block number. For example, if current block has number 300, then the number here will be 44..300, like:
But after more thought on this, I think we should keep it simpler for verifier to have as 0..256, since the constraints of BLOCKHASH would be almost same (differs on whether to subtract block.number or not).
Will try to update it in further PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've included the updates from #88 in the tables.