Skip to content
This repository was archived by the owner on Jul 5, 2024. It is now read-only.

markdown spec for invalid_creation_code error#400

Closed
DreamWuGit wants to merge 5 commits into
privacy-ethereum:masterfrom
scroll-tech:invalid_creation_code
Closed

markdown spec for invalid_creation_code error#400
DreamWuGit wants to merge 5 commits into
privacy-ethereum:masterfrom
scroll-tech:invalid_creation_code

Conversation

@DreamWuGit
Copy link
Copy Markdown
Collaborator

@DreamWuGit DreamWuGit commented Mar 13, 2023

@DreamWuGit DreamWuGit mentioned this pull request Mar 13, 2023
Merged
1 task
@DreamWuGit DreamWuGit marked this pull request as ready for review March 14, 2023 08:58
@ed255 ed255 requested a review from hero78119 April 13, 2023 11:13
@ed255 ed255 requested a review from leolara April 27, 2023 12:01
@ChihChengLiang
Copy link
Copy Markdown
Collaborator

ChihChengLiang commented May 18, 2023

pending on the circuit PR privacy-ethereum/zkevm-circuits#1292

@ChihChengLiang
Copy link
Copy Markdown
Collaborator

ChihChengLiang commented Jun 22, 2023

@silathdiir is this PR ready for review?

@silathdiir
Copy link
Copy Markdown
Contributor

silathdiir commented Jun 22, 2023

Yes, thanks. And also the related circuit PR privacy-ethereum/zkevm-circuits#1292.

Please help review when you have time. Thanks.

@ChihChengLiang
Copy link
Copy Markdown
Collaborator

ChihChengLiang commented Jun 28, 2023

Pending updates from @silathdiir as the circuit pr review suggests privacy-ethereum/zkevm-circuits#1292 (review)

github-merge-queue Bot pushed a commit to privacy-ethereum/zkevm-circuits that referenced this pull request Jul 7, 2023
@DreamWuGit @silathdiir
circuit for invalid creation code (#1292)
3733326 
### Description

circuit for invalid creation code error in create, markdown spec
privacy-ethereum/zkevm-specs#400
### Issue Link

issue #1291 

### Type of change

- [x] New feature (non-breaking change which adds functionality)

### Rationale

Get first byte of code to store , check it is 0xef

This PR contains:
- buss mapping: at the return opcode in create, get the first byte .
- add circuit & test 
- add tx deploy trace test .

---------

Co-authored-by: Steven Gu <asongala@163.com>
@ed255
Copy link
Copy Markdown
Contributor

ed255 commented Jul 13, 2023

@silathdiir kindly ping to remind about updating this spec according to the merged circuit PR. Let us know if you need help with anything!

@silathdiir
Copy link
Copy Markdown
Contributor

silathdiir commented Jul 13, 2023

@silathdiir kindly ping to remind about updating this spec according to the merged circuit PR. Let us know if you need help with anything!

Sorry for delay. Will try to continue on this PR in this month (add invalid_creation_code spec code and update return_revert spec).

This was referenced Jul 25, 2023
Closed
Closed
Merged
@KimiWu123
Copy link
Copy Markdown
Contributor

KimiWu123 commented Jul 31, 2023

moved to #478

@KimiWu123 KimiWu123 closed this Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hero78119 hero78119 Awaiting requested review from hero78119

@leolara leolara Awaiting requested review from leolara

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The InvalidCreationCode Error

5 participants

@DreamWuGit @ChihChengLiang @silathdiir @ed255 @KimiWu123