spec for codestore error#393
Conversation
CPerezz
left a comment
CPerezz
left a comment
There was a problem hiding this comment.
Some changes for the text. Constraints look good.
|
|
||
| ### Constraints | ||
| 1. `code_store_cost` > gas_left or `length` > `MAXCODESIZE` | ||
| 2. Current call must be failed. |
There was a problem hiding this comment.
Current call should not be STATICALL. Do we need to highlight it here?
There was a problem hiding this comment.
@CPerezz you are right ! will add this constraint.
There was a problem hiding this comment.
Aside from this one, I wonder if we're missing something else. Specially regarding call-depth or similar.
There was a problem hiding this comment.
oh, I realize that each constraint you mention has its error gadget handling. like if create in STATICALL , ErrorWriteProtection gadget will handle it. if call-depth exceeds, it will go to ErrorDepth gadget side. so I don't think need check each one. otherwise we are going to ensure all other errors of create(ErrDepth, ErrInsufficientBalance, ErrContractAddressCollision , ErrInvalidCode etc.) not happens. WDYT?
There was a problem hiding this comment.
added non static call constraint in cbb1600
Co-authored-by: Carlos Pérez <37264926+CPerezz@users.noreply.github.com>
CPerezz
left a comment
CPerezz
left a comment
There was a problem hiding this comment.
LGTM!!
Thanks @DreamWuGit !
2 participants
spec issue #394
circuit PR is privacy-ethereum/zkevm-circuits#1265
CodeStoreOutOfGasandMaxCodeSizeExceeded