This repository was archived by the owner on Jul 5, 2024. It is now read-only.
Markdown doc for ErrorOutOfGasEXP state#388
Merged
Merged
Conversation
This was referenced Feb 22, 2023
lispc
pushed a commit
to privacy-ethereum/zkevm-circuits
that referenced
this pull request
Feb 23, 2023
### Description Add `ErrorOOGExpGadget` to handle OOG error of `EXP` opcode. Gas calculation could reference [this go-ethereum function](https://github.com/ethereum/go-ethereum/blob/master/core/vm/gas_table.go#L351). Spec Markdown PR privacy-ethereum/zkevm-specs#388 ### Issue Link Close #1231 ### Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ### How Has This Been Tested? Tested with unit-test cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Markdown doc for
EXPOOG eror.Gas calculation could reference this go-ethereum function.
Circuit PR privacy-ethereum/zkevm-circuits#1232