This repository was archived by the owner on Jul 5, 2024. It is now read-only.
feat: update account non-existence handling#354
Merged
Conversation
ed255
commented
Jan 6, 2023
| except AssertionError as e: | ||
| ok = False | ||
| assert ok == success | ||
| exception = e |
Contributor
Author
There was a problem hiding this comment.
I made this change so that when tests fail with success = True, the exception is raised so that it's presented to the user (instead of being captured and just seeing an AssertionError)
ed255
force-pushed
the
feature/non-exist-code_hash
branch
from
d6a0876 to
87a6be2
Compare
han0110
approved these changes
Jan 9, 2023
Contributor
han0110
left a comment
han0110
left a comment
There was a problem hiding this comment.
All LGTM! With the updated document it's much more clear now. Nice work!
Change the approach to handle non-existing accounts by 1. Using `code_hash = 0` as a non-existing account state 2. Doing accont non-existence MPT proofs from the State Circuit on the where an account update is CodeHash and goes 0->0. Resolve #259
ed255
force-pushed
the
feature/non-exist-code_hash
branch
from
87a6be2 to
87ca93a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the approach to handle non-existing accounts by
code_hash = 0as a non-existing account stateResolve #259