Skip to content
This repository was archived by the owner on Jul 5, 2024. It is now read-only.

code_source rename to code_hash#205

Merged
ed255 merged 2 commits into
privacy-ethereum:masterfrom
scroll-tech:fix/code-hash-renaming
May 25, 2022
Merged

code_source rename to code_hash#205
ed255 merged 2 commits into
privacy-ethereum:masterfrom
scroll-tech:fix/code-hash-renaming

Conversation

@roynalnaruto
Copy link
Copy Markdown
Collaborator

@roynalnaruto roynalnaruto commented May 23, 2022

This PR targets #73 partially. After this is merged, we can proceed with #191

@roynalnaruto roynalnaruto force-pushed the fix/code-hash-renaming branch from 7f27898 to 8a8c985 Compare May 24, 2022 02:08
Copy link
Copy Markdown
Collaborator

@ChihChengLiang ChihChengLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for addressing this :) Please take a look at my suggestion; otherwise LGTM!

Comment thread src/zkevm_specs/evm/execution/begin_tx.py Outdated
Copy link
Copy Markdown
Contributor

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ed255 ed255 merged commit 10cf55b into privacy-ethereum:master May 25, 2022
@roynalnaruto roynalnaruto mentioned this pull request May 26, 2022
@roynalnaruto roynalnaruto deleted the fix/code-hash-renaming branch August 22, 2022 13:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants