Skip to content
This repository was archived by the owner on Jul 5, 2024. It is now read-only.

add TxReceipt constraint in begin&end tx#181

Merged
ed255 merged 7 commits into
privacy-ethereum:masterfrom
scroll-tech:tx_logid
Apr 29, 2022
Merged

add TxReceipt constraint in begin&end tx#181
ed255 merged 7 commits into
privacy-ethereum:masterfrom
scroll-tech:tx_logid

Conversation

@DreamWuGit
Copy link
Copy Markdown
Collaborator

@DreamWuGit DreamWuGit commented Apr 13, 2022 •
edited
Loading

this PR aims to resolve issue #177 to add constraint to TxReceipt tag.

  • (1) In begin_Tx gadget, log_id should reset to zero at the beginning.
    In end_tx gadget, log_id should match with LogLength of TxReceipt RW table.
  • (2) PostStateOrStatus should be equal to tx status in end_tx
  • (3) current receipt's CumulativeGasUsed =.pre receipt's CumulativeGasUsed + current tx gas cost

@DreamWuGit DreamWuGit marked this pull request as ready for review April 14, 2022 07:41
@DreamWuGit DreamWuGit requested review from a team and CPerezz April 14, 2022 07:41
@DreamWuGit DreamWuGit changed the title add logid constraint in begin&end tx add TxReceipt constraint in begin&end tx Apr 14, 2022
CPerezz
CPerezz reviewed Apr 14, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@CPerezz CPerezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a first review round.

So far looking good! 👍

Comment thread src/zkevm_specs/evm/execution/end_tx.py Outdated
Comment thread src/zkevm_specs/evm/instruction.py Outdated
Comment thread src/zkevm_specs/evm/instruction.py Outdated
@DreamWuGit DreamWuGit mentioned this pull request Apr 19, 2022
Merged
4 tasks
@DreamWuGit
Copy link
Copy Markdown
Collaborator Author

DreamWuGit commented Apr 20, 2022

@ed255 Could you also have a look ?

han0110
han0110 reviewed Apr 22, 2022
View reviewed changes
Comment thread src/zkevm_specs/evm/execution/begin_tx.py Outdated
Comment thread tests/evm/test_end_tx.py Outdated
Comment thread src/zkevm_specs/evm/execution/end_tx.py
ed255
ed255 approved these changes Apr 28, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for working on this :)

CPerezz
CPerezz approved these changes Apr 28, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@CPerezz CPerezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ed255 ed255 merged commit fa74561 into privacy-ethereum:master Apr 29, 2022
@ChihChengLiang ChihChengLiang mentioned this pull request May 4, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@han0110 han0110 han0110 left review comments

@ed255 ed255 ed255 approved these changes

@CPerezz CPerezz CPerezz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DreamWuGit @han0110 @ed255 @CPerezz