Skip to content
This repository was archived by the owner on Jul 5, 2024. It is now read-only.

Spec for opcode ISZERO#157

Merged
icemelon merged 17 commits into
privacy-ethereum:masterfrom
scroll-tech:feat/opcode-is-zero
Mar 31, 2022
Merged

Spec for opcode ISZERO#157
icemelon merged 17 commits into
privacy-ethereum:masterfrom
scroll-tech:feat/opcode-is-zero

Conversation

@silathdiir
Copy link
Copy Markdown
Contributor

@silathdiir silathdiir commented Mar 23, 2022

silathdiir and others added 9 commits March 23, 2022 16:08
Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com>
Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

fix typos
Comment thread src/zkevm_specs/evm/execution/iszero.py Outdated
Copy link
Copy Markdown
Collaborator

@DreamWuGit DreamWuGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Co-authored-by: DreamWuGit <wwuwwei@126.com>
Comment thread src/zkevm_specs/evm/execution/iszero.py
@silathdiir silathdiir requested a review from icemelon March 29, 2022 02:51
Copy link
Copy Markdown
Collaborator

@icemelon icemelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments. otherwise LGTM

Comment thread specs/opcode/15ISZERO.md Outdated
Comment thread specs/opcode/15ISZERO.md Outdated
silathdiir and others added 2 commits March 31, 2022 14:06
Co-authored-by: Haichen Shen <shenhaichen@gmail.com>
Co-authored-by: Haichen Shen <shenhaichen@gmail.com>
@icemelon icemelon merged commit a5bff90 into privacy-ethereum:master Mar 31, 2022
@icemelon icemelon deleted the feat/opcode-is-zero branch March 31, 2022 06:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants