This repository was archived by the owner on Jul 5, 2024. It is now read-only.
Change line-length from 120 to 100#117
Merged
Merged
Conversation
Closed
ed255
approved these changes
Feb 15, 2022
Contributor
ed255
left a comment
ed255
left a comment
There was a problem hiding this comment.
LGTM! Please take a look at the comment for a discussion about formatting skipping for test vectors.
| rw_table=set( | ||
| [ | ||
| (1, RW.Read, RWTableTag.CallContext, 1, CallContextFieldTag.TxId, 0, tx.id, 0, 0, 0), | ||
| ( |
Contributor
There was a problem hiding this comment.
Do you think it's acceptable to skip the format check for test vectors? Like so: https://github.com/appliedzkp/zkevm-specs/blob/45842edfcdeda4744cf5414728c4d32a4a677473/tests/test_state_circuit.py#L27
I think having this exception can make the test code more readable.
Collaborator
Author
There was a problem hiding this comment.
That sounds good! Will do.
ChihChengLiang
force-pushed
the
change-lint
branch
3 times, most recently
from
2dcbf4e to
b4dd471
Compare
ChihChengLiang
force-pushed
the
change-lint
branch
from
b4dd471 to
4b8cfdf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
120 is too long, change it to 100 to be consistent with the circuit repo.