This repository was archived by the owner on Jul 5, 2024. It is now read-only.
Specs for opcode TIMESTAMP (0x42)#105
Merged
Merged
Conversation
DreamWuGit
approved these changes
Jan 26, 2022
Collaborator
DreamWuGit
left a comment
DreamWuGit
left a comment
There was a problem hiding this comment.
LGTM, need to fix build error!
ed255
suggested changes
Jan 27, 2022
ed255
approved these changes
Jan 31, 2022
Contributor
ed255
left a comment
ed255
left a comment
There was a problem hiding this comment.
The applied changes look good! Thanks for the work :)
There's been an update to black, the python formatter we are using: https://github.com/psf/black/releases/tag/22.1.0 which seems to change the formatting a bit from the previous versions. Please, update your installation of black and run black . to pass the github actions lint check. After that we can merge the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.