Skip to content
This repository was archived by the owner on Jul 5, 2024. It is now read-only.

fix: Return to patch usage for halo2 deps#729

Closed
CPerezz wants to merge 1 commit into
mainfrom
use_patch
Closed

fix: Return to patch usage for halo2 deps#729
CPerezz wants to merge 1 commit into
mainfrom
use_patch

Conversation

@CPerezz
Copy link
Copy Markdown
Contributor

@CPerezz CPerezz commented Sep 2, 2022

In #724 the patch wasn't working with 0.1.0-beta so it was left as
TODO.

But thanks to @pinkiebell who pointed out that it was required to bump
the base dep in the multiple Cargo.tomls this was solved.

@CPerezz
fix: Return to patch usage for halo2 deps
c1ef54a 
In #724 the patch wasn't working with `0.1.0-beta` so it was left as
TODO.

But thanks to @pinkiebell who pointed out that it was required to bump
the base dep in the multiple Cargo.tomls this was solved.
@CPerezz CPerezz requested a review from ed255 as a code owner September 2, 2022 07:10
@github-actions github-actions Bot added crate-bus-mapping Issues related to the bus-mapping workspace member crate-circuit-benchmarks Issues related to the circuit-benchmarks workspace member crate-eth-types Issues related to the eth-types workspace member crate-gadgets Issues related to the gadgets workspace member crate-integration-tests Issues related to the integration-tests workspace member T-bench Type: benchmark improvements labels Sep 2, 2022
@CPerezz CPerezz requested review from ChihChengLiang and removed request for ed255 September 2, 2022 07:10
@CPerezz CPerezz mentioned this pull request Sep 2, 2022
Merged
@pinkiebell
Copy link
Copy Markdown
Contributor

pinkiebell commented Sep 2, 2022

@CPerezz I just found out that if I add zkevm-circuits as dependency to an external crate (prover), it fails to resolve the correct halo2 because it ignores the patch statements. So I think it makes actually sense to keep the current style of { git = } everywhere and avoid using [patch].

@CPerezz
Copy link
Copy Markdown
Contributor Author

CPerezz commented Sep 2, 2022

Closing as discussed in the meeting 2022-09-02.
Let's go on this new direction of updating the deps on each crate.

Thanks @pinkiebell

@CPerezz CPerezz closed this Sep 2, 2022
@CPerezz CPerezz deleted the use_patch branch September 2, 2022 07:45
lispc pushed a commit that referenced this pull request Aug 28, 2023
@noel2004
[Fix] caller account not exist in l1msg (#729)
5740543 
* create account for empty l1 messenger account

* * do not touch sdb for l1fee in l1 msg tx
* lint and fmt
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@han0110 han0110 Awaiting requested review from han0110

@pinkiebell pinkiebell Awaiting requested review from pinkiebell

@ChihChengLiang ChihChengLiang Awaiting requested review from ChihChengLiang

Assignees

No one assigned

Labels

crate-bus-mapping Issues related to the bus-mapping workspace member crate-circuit-benchmarks Issues related to the circuit-benchmarks workspace member crate-eth-types Issues related to the eth-types workspace member crate-gadgets Issues related to the gadgets workspace member crate-integration-tests Issues related to the integration-tests workspace member T-bench Type: benchmark improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CPerezz @pinkiebell