This repository was archived by the owner on Jul 5, 2024. It is now read-only.
Fixed-value randomness tests#682
Merged
Merged
Conversation
github-actions
Bot
added
crate-circuit-benchmarks
…-circuits into seeded_randomness_tests
z2trillion
referenced
this pull request
in scroll-tech/zkevm-circuits
Aug 18, 2022
This reverts commit de17e38.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So as per comment in #641 and discussion in #622 (comment) I've just used a constant value for all of the randomness-related tests.
As per my opinion, I think this is going to make it a bit more difficult to enforce consistency on the randomness used. And, instead, we should try to go for something like a lazy_static defined randomness value in the
mockcrate which can be used elsewhere.I think this second option would make more sense. And I'm happy to open a new PR with that approach :)