This repository was archived by the owner on Jul 5, 2024. It is now read-only.
FIX constraints+tests for copy circuit and SHA3 gadget#668
Merged
roynalnaruto merged 8 commits intoAug 11, 2022
Conversation
github-actions
Bot
added
the
crate-zkevm-circuits
github-actions
Bot
added
the
crate-bus-mapping
lispc
approved these changes
Aug 9, 2022
roynalnaruto
changed the title
DreamWuGit
reviewed
Aug 11, 2022
jonathanpwang
pushed a commit
to axiom-crypto/zkevm-circuits
that referenced
this pull request
Aug 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
read value == write valueshould not be present forRlcAccrowread value == write valuealways being true for the first row, was not presentsize == 0case was not handled inSHA3gadget. This has been fixed, with a test case.