This repository was archived by the owner on Jul 5, 2024. It is now read-only.
Fix RLC values in Copy/Keccak table lookup (SHA3)#655
Merged
Conversation
github-actions
Bot
added
the
crate-zkevm-circuits
Collaborator
|
this pr looks good to me. But what about also fixing integration test in this PR? |
Collaborator
Author
Adding a commit now to fix that! |
github-actions
Bot
added
the
crate-bus-mapping
Collaborator
Author
|
Because of the Keccak table assignment update, the bytecode tests are failing. Will fix the bytecode config assignment as well. |
roynalnaruto
force-pushed
the
fix/sha3-gadget
branch
from
007cfc8 to
252f181
Compare
roynalnaruto
changed the title
lispc
reviewed
Aug 5, 2022
lispc
approved these changes
Aug 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
integration-testswarning after merging #635 forSHA3using a dummy gadget.Still investigating failure because of Keccak lookup.