This repository was archived by the owner on Jul 5, 2024. It is now read-only.
zkevm-circuits: add pub visibility for SuperCircuit fields and add re…#652
Merged
Conversation
…-exports of common structs for SuperCircuit consumers. Makes it a bit easier for external crates to consume the SuperCircuit.
github-actions
Bot
added
the
crate-zkevm-circuits
ChihChengLiang
approved these changes
Aug 11, 2022
Collaborator
ChihChengLiang
left a comment
ChihChengLiang
left a comment
There was a problem hiding this comment.
LGTM, after a rebase
Contributor
|
Will rebase and merge this after #654 is merged. So that the PR doesn't get stale. |
Contributor
|
Thanks for the fix @pinkiebell <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…-exports of common structs for SuperCircuit consumers.
Makes it a bit easier for external crates to consume the SuperCircuit.