This repository was archived by the owner on Jul 5, 2024. It is now read-only.
chore(github CI): use pull_request_target event for external reveiwers#479
Closed
0xmountaintop wants to merge 1 commit into
Closed
chore(github CI): use pull_request_target event for external reveiwers#4790xmountaintop wants to merge 1 commit into
pull_request_target event for external reveiwers#4790xmountaintop wants to merge 1 commit into
Conversation
0xmountaintop
requested review from
a team and
ChihChengLiang
and removed request for
a team
github-actions
Bot
added
the
CI
Collaborator
Author
|
Hmmm not sure how to trigger "Reviewer lottery" action (as in #467) to verify this change works. |
Collaborator
|
@HAOYUatHZ I got it in #481 again, perhaps I can help you to verify this. :) |
Contributor
|
It was decided to remove this workflow for now and simply ping Scroll members for PR reviews. As there's no way to overpass the permission system for PR setup.. I suggest we close this for now and we don't loose more time :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.