This repository was archived by the owner on Jul 5, 2024. It is now read-only.
feat: bus mapping for sload and sstore#436
Merged
CPerezz merged 9 commits intoApr 8, 2022
Merged
Conversation
Contributor
|
Hey @ChihChengLiang I can take this as I already reviewed the previous PR related to this. So I have the background already. As you prefer, but happy to do it! :) |
CPerezz
suggested changes
Apr 7, 2022
Contributor
CPerezz
left a comment
There was a problem hiding this comment.
Overall looks good!! Thanks for working on this!
Left some comments and questions! :)
Contributor
Not sure I follow. But I think that it's safe to have tests in both sides even if they have some overlap TBH. As they might help to catch different kinds of errors as well as different missing API methods or similar stuff. |
11 tasks
This was referenced Apr 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some explanation:
dirty_storageis added to statedb.rs, just like StateDB in go-ethereum.refundin trace.Some review comments from old PR #418
refundand geth docker image upgrade, comments added in docker compose file in integration tests*referencerather thanreference.clone()A questions:
in zkevm circuits, if the tests are already written in bus mapping, will it be reasonable to write very similar tests in bus mapping again?