This repository was archived by the owner on Jul 5, 2024. It is now read-only.
Fix integration test#389
Merged
Merged
Conversation
github-actions
Bot
added
the
crate-bus-mapping
CPerezz
approved these changes
Mar 14, 2022
Contributor
CPerezz
left a comment
CPerezz
left a comment
There was a problem hiding this comment.
LGTM.
Also, not sure but we should file issues for these things if we don't already have them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #312, getting missing accounts when parsing is made to be always error, and creation tx is treated unimplemented (to panic). But the integration test is forgot to be taken into consideration.
This PR aims to add the missing
block.authorintoAccessSet, and remove theunimplemented!when seeing creation tx or calling to precompiled.