This repository was archived by the owner on Jul 5, 2024. It is now read-only.
MPT: merge with main only#1530
Merged
Merged
Conversation
github-actions
Bot
added
CI
4 tasks
ChihChengLiang
approved these changes
Jul 18, 2023
Collaborator
ChihChengLiang
left a comment
ChihChengLiang
left a comment
There was a problem hiding this comment.
LGTM, as this is a merging main PR.
miha-stopar
approved these changes
Jul 18, 2023
Collaborator
|
Hi @Brechtpd, what's the status of this PR? Anything we can help? |
Collaborator
Author
|
This PR could be merged into the So I was thinking merging #1531 first so the branch |
Collaborator
|
Ｗonderful. Merging #1531 first sounds good. |
#1531) This PR is currently against to intermediate PR #1530 that just merges in the main, so the diff is cleaner. - Updates the MPT branch for the latest main - lo/hi support - Challenge API integration - keccak endianness change - Added preimage checks for keys used in the tree paths - Performance improvements (expressions degree can and is reduced to 5) - Misc other small improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Just merges the MPT branch with the master, without fixing any issues (and so breaks the code). The actual merge is done in #1531, the only purpose of this PR is to have a nicer diff for the other PR without breaking the code in the current
mpt2branch.Issue Link
[link issue here]
Type of change
Contents
Rationale
[design decisions and extended information]
How Has This Been Tested?