This repository was archived by the owner on Jul 5, 2024. It is now read-only.
Combine LookupU8 and LookupU16 under Lookup(Table)#1514
Merged
ChihChengLiang merged 5 commits intoJul 6, 2023
Conversation
github-actions
Bot
added
the
crate-zkevm-circuits
zemse
force-pushed
the
1510-combine-lookup-u8-u16
branch
from
4e3aa7a to
5c2b437
Compare
hero78119
reviewed
Jul 5, 2023
hero78119
approved these changes
Jul 6, 2023
Contributor
hero78119
left a comment
hero78119
left a comment
There was a problem hiding this comment.
LGTM! thanks for the contribution 🥇
ChihChengLiang
approved these changes
Jul 6, 2023
Collaborator
ChihChengLiang
left a comment
ChihChengLiang
left a comment
There was a problem hiding this comment.
LGTM. Beautiful refactor. Thanks for the contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Combines LookupU8 and LookupU16 under Lookup(Table).
Issue Link
#1510
Type of change