Skip to content
This repository was archived by the owner on Jul 5, 2024. It is now read-only.

MPT new descriptors & benchmark#1492

Merged
miha-stopar merged 7 commits into
mpt2from
mpt-new-descriptors
Jun 26, 2023
Merged

MPT new descriptors & benchmark#1492
miha-stopar merged 7 commits into
mpt2from
mpt-new-descriptors

Conversation

@miha-stopar
Copy link
Copy Markdown
Collaborator

@miha-stopar miha-stopar commented Jun 22, 2023 •
edited
Loading

Description

New descriptors are used which have Vec<Node> structure and thus the conversion in witness_row.rs from [][]byte to Vec<Node> was removed. Note that keccak_data is now part of the Node struct - each node holds the byte streams that need to be hashed.

Additionally, an MPT benchmark was added (some structs needed to be made public).

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Contents

  • All tests updated.
  • prepare_witness function removed from witness_row.rs.
  • MPT test updated to not use prepare_witness.
  • Benchmark added.

@miha-stopar miha-stopar requested a review from Brechtpd June 22, 2023 12:50
@github-actions github-actions Bot added the crate-zkevm-circuits Issues related to the zkevm-circuits workspace member label Jun 22, 2023
@github-actions github-actions Bot added crate-circuit-benchmarks Issues related to the circuit-benchmarks workspace member T-bench Type: benchmark improvements labels Jun 22, 2023
@miha-stopar miha-stopar changed the title MPT new descriptors MPT new descriptors & benchmark Jun 22, 2023
Brechtpd
Brechtpd reviewed Jun 22, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Brechtpd Brechtpd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for doing the witness refactor!

I think there's something up with the benchmark, but otherwise looks great.

Comment thread circuit-benchmarks/src/mpt_circuit.rs Outdated
Comment thread circuit-benchmarks/src/mpt_circuit.rs Outdated
Comment thread circuit-benchmarks/src/mpt_circuit.rs Outdated
Comment thread zkevm-circuits/src/mpt_circuit/witness_row.rs Outdated
@miha-stopar miha-stopar merged commit d341d7a into mpt2 Jun 26, 2023
@miha-stopar miha-stopar deleted the mpt-new-descriptors branch June 26, 2023 12:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@Brechtpd Brechtpd Brechtpd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

crate-circuit-benchmarks Issues related to the circuit-benchmarks workspace member crate-zkevm-circuits Issues related to the zkevm-circuits workspace member T-bench Type: benchmark improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@miha-stopar @Brechtpd