Skip to content
This repository was archived by the owner on Jul 5, 2024. It is now read-only.

[word lo/hi] add ci subcircuit unit test and fix address assignment #1488

Merged
hero78119 merged 3 commits into
word-lo-hifrom
feat/fix_address_and_unittest
Jun 21, 2023
Merged

[word lo/hi] add ci subcircuit unit test and fix address assignment #1488
hero78119 merged 3 commits into
word-lo-hifrom
feat/fix_address_and_unittest

Conversation

@hero78119
Copy link
Copy Markdown
Contributor

@hero78119 hero78119 commented Jun 21, 2023 •
edited
Loading

Description

Add back

  • evm_circuit
  • keccak_circuit
  • exp_circuit
  • pi_circuit
  • state_circuit

unittest to ci

Other subcircuit tx_circuit/copy_circuit/bytecode_circuit/root_circuit still failed for now, will be fixed in another pr

Issue Link

N/A

Type of change

  • New feature (non-breaking change which adds functionality)

Contents

  • Fix unittest assertion failed due to sanity check on address H160 retrieved from U256. We need to clean up MSB 12 bytes to 0
  • add subcircuit light tests on CI in whitelist based

@hero78119 hero78119 mentioned this pull request Jun 21, 2023
Merged
4 tasks
@hero78119 hero78119 force-pushed the feat/fix_address_and_unittest branch from 224e0d0 to f82356f Compare June 21, 2023 03:56
@hero78119 hero78119 changed the title [word lo/hi] fix address assignment and add ci evm unit test [word lo/hi] fix address assignment and add ci subcircuit unit test Jun 21, 2023
@hero78119 hero78119 changed the title [word lo/hi] fix address assignment and add ci subcircuit unit test [word lo/hi] add ci subcircuit unit test and fix address assignment Jun 21, 2023
@KimiWu123 KimiWu123 self-requested a review June 21, 2023 04:13
@hero78119 hero78119 mentioned this pull request Jun 21, 2023
Merged
2 tasks
KimiWu123
KimiWu123 approved these changes Jun 21, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@KimiWu123 KimiWu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hero78119 hero78119 force-pushed the feat/fix_address_and_unittest branch from f4abb8f to 9b2610b Compare June 21, 2023 06:26
@hero78119
Copy link
Copy Markdown
Contributor Author

hero78119 commented Jun 21, 2023

resolved #1477 and #1476

@KimiWu123
Copy link
Copy Markdown
Contributor

KimiWu123 commented Jun 21, 2023

tx_circuit passed in #1418

@hero78119
Copy link
Copy Markdown
Contributor Author

hero78119 commented Jun 21, 2023

tx_circuit passed in #1418

👍 it's good. @KimiWu123 do you think I merge this first, since it just small pr, I think 1 reviewer is ok. So other word-lo-hi pr e.g. #1418 can add tx_circuit back on the same ci file

ed255
ed255 approved these changes Jun 21, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hero78119 hero78119 merged commit cb6c17c into word-lo-hi Jun 21, 2023
@hero78119 hero78119 deleted the feat/fix_address_and_unittest branch June 21, 2023 13:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@KimiWu123 KimiWu123 KimiWu123 approved these changes

@ed255 ed255 ed255 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hero78119 @KimiWu123 @ed255