Skip to content
This repository was archived by the owner on Jul 5, 2024. It is now read-only.

add overall cell utilization statistics#1486

Merged
hero78119 merged 1 commit into
mainfrom
feat/overall_cell_utilization
Jul 4, 2023
Merged

add overall cell utilization statistics#1486
hero78119 merged 1 commit into
mainfrom
feat/overall_cell_utilization

Conversation

@hero78119
Copy link
Copy Markdown
Contributor

@hero78119 hero78119 commented Jun 19, 2023 •
edited
Loading

Description

Add overall summary for cell utilization

Issue Link

N/A

Type of change

  • New feature (non-breaking change which adds functionality)

Contents

  • sum of available_cells
  • sum of unused_cells
  • Utilization #unused_cells/#available_cells

Example output

Storage_1

Main:
+-----------------------------------+------------------------------+-------------------------+
| "storage_1" total_available_cells | "storage_1" total_used_cells | "storage_1" Utilization (%) |
+-----------------------------------+------------------------------+-------------------------+
| 25480                             | 6482                         | 25.4                    |
+-----------------------------------+------------------------------+-------------------------+

Word-lo-hi
+-----------------------------------+------------------------------+-----------------------------+
| "storage_1" total_available_cells | "storage_1" total_used_cells | "storage_1" Utilization (%) |
+-----------------------------------+------------------------------+-----------------------------+
| 24080                             | 7078                         | 29.4                        |
+-----------------------------------+------------------------------+-----------------------------+

Storage_2

Main
+-----------------------------------+------------------------------+-------------------------+
| "storage_2" total_available_cells | "storage_2" total_used_cells | "storage_2" Utilization |
+-----------------------------------+------------------------------+-------------------------+
| 1456                              | 467                          | 32.1                    |
+-----------------------------------+------------------------------+-------------------------+

Word-lo-hi
+-----------------------------------+------------------------------+-----------------------------+
| "storage_2" total_available_cells | "storage_2" total_used_cells | "storage_2" Utilization (%) |
+-----------------------------------+------------------------------+-----------------------------+
| 1376                              | 14                           | 1.0                         |
+-----------------------------------+------------------------------+-----------------------------+

Byte_lookup

Main

+-------------------------------------+--------------------------------+---------------------------+
| "byte_lookup" total_available_cells | "byte_lookup" total_used_cells | "byte_lookup" Utilization |
+-------------------------------------+--------------------------------+---------------------------+
| 8736                                | 6786                           | 77.7                      |
+-------------------------------------+--------------------------------+---------------------------+

Word-lo-hi
+-------------------------------------+--------------------------------+-------------------------------+
| "byte_lookup" total_available_cells | "byte_lookup" total_used_cells | "byte_lookup" Utilization (%) |
+-------------------------------------+--------------------------------+-------------------------------+
| 8256                                | 6566                           | 79.5                          |
+-------------------------------------+--------------------------------+-------------------------------+

@github-actions github-actions Bot added the crate-zkevm-circuits Issues related to the zkevm-circuits workspace member label Jun 19, 2023
@hero78119 hero78119 mentioned this pull request Jun 19, 2023
Merged
8 tasks
@hero78119 hero78119 force-pushed the feat/overall_cell_utilization branch 2 times, most recently from 6b8284c to 99e86e8 Compare June 27, 2023 05:57
@hero78119 hero78119 force-pushed the feat/overall_cell_utilization branch from eac0484 to 57929e2 Compare July 4, 2023 01:56
@ChihChengLiang ChihChengLiang self-requested a review July 4, 2023 06:49
ChihChengLiang
ChihChengLiang approved these changes Jul 4, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ChihChengLiang ChihChengLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
For people who would like to try this, run cargo run --bin stats --features="stats" -- exec.

@KimiWu123 KimiWu123 self-requested a review July 4, 2023 07:58
KimiWu123
KimiWu123 approved these changes Jul 4, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@KimiWu123 KimiWu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hero78119 hero78119 added this pull request to the merge queue Jul 4, 2023
Merged via the queue into main with commit 8030de3 Jul 4, 2023
@hero78119 hero78119 deleted the feat/overall_cell_utilization branch July 4, 2023 08:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@ChihChengLiang ChihChengLiang ChihChengLiang approved these changes

@KimiWu123 KimiWu123 KimiWu123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

crate-zkevm-circuits Issues related to the zkevm-circuits workspace member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hero78119 @ChihChengLiang @KimiWu123