Skip to content
This repository was archived by the owner on Jul 5, 2024. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
6892bca
Integration tests: cache keys for EVM test
leolara Jan 23, 2023
e9bbc94
Merge branch 'main' into leo/integration-tests-cache-keys-evm
leolara Jan 30, 2023
d5e60a7
Make EVM keys generation based on an actual block
leolara Jan 30, 2023
24367fe
Merge branch 'main' into leo/integration-tests-cache-keys-evm
leolara Feb 7, 2023
4b788bd
Rename max_evm_rows
leolara Feb 7, 2023
8e28098
Move max_evm_rows to CircuitParams
leolara Feb 7, 2023
67a04ad
Set MAX_EVM_ROWS in integration tests
leolara Feb 7, 2023
08321b5
Use the cached pv again
leolara Feb 7, 2023
4651f34
Detect max evm rows in EVM circuit
leolara Feb 7, 2023
663363f
Merge branch 'main' into leo/integration-tests-cache-keys-evm
leolara Feb 8, 2023
704c2cf
Remove async_once
leolara Feb 8, 2023
db5f002
Fix code in comment
leolara Feb 8, 2023
c0309fc
Remove leftover line
leolara Feb 8, 2023
f1e8986
Fix rows required panic
leolara Feb 8, 2023
20c06fe
Merge branch 'main' into leo/integration-tests-cache-keys-evm
leolara Feb 9, 2023
e13eb5b
Better comments
leolara Feb 9, 2023
4518636
Add max_evm_rows to root circuit
leolara Feb 9, 2023
abd3247
Experiment 1
leolara Feb 9, 2023
cb7ee6c
Better integration tests
leolara Feb 11, 2023
6520ff2
Some cleaning
leolara Feb 11, 2023
e4a83bf
Small fix
leolara Feb 11, 2023
39626dc
Merge branch 'main' into leo/integration-tests-cache-keys-evm
leolara Feb 14, 2023
ebc34fc
Merge branch 'main' into leo/integration-tests-cache-keys-evm
leolara Feb 15, 2023
c27b089
Merge branch 'main' into leo/integration-tests-cache-keys-evm
leolara Feb 16, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions bus-mapping/src/circuit_input_builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,12 @@ pub struct CircuitsParams {
pub max_exp_steps: usize,
/// Maximum number of bytes supported in the Bytecode Circuit
pub max_bytecode: usize,
/// Pad evm circuit number of rows.
/// When 0, the EVM circuit number of row will be dynamically calculated, so
/// the same circuit will not be able to proof different witnesses. In this
/// case it will contain as many rows for all steps + 1 row
/// for EndBlock.
pub max_evm_rows: usize,
// TODO: Rename for consistency
/// Pad the keccak circuit with this number of invocations to a static
/// capacity. Number of keccak_f that the Keccak circuit will support.
Expand All @@ -70,6 +76,7 @@ impl Default for CircuitsParams {
max_copy_rows: 1000,
max_exp_steps: 1000,
max_bytecode: 512,
max_evm_rows: 0,
keccak_padding: None,
}
}
Expand Down
1 change: 1 addition & 0 deletions circuit-benchmarks/src/super_circuit.rs
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ mod tests {
max_copy_rows: 256,
max_exp_steps: 256,
max_bytecode: 512,
max_evm_rows: 0,
keccak_padding: None,
};
let (_, circuit, instance, _) =
Expand Down
Loading