This repository was archived by the owner on Jul 5, 2024. It is now read-only.
fix delegate call with insufficient balance#1069
Merged
ed255 merged 5 commits intoJan 20, 2023
Merged
Conversation
github-actions
Bot
added
crate-bus-mapping
lispc
reviewed
Jan 16, 2023
…-tech/zkevm-circuits into delegatecall_insufficient
ed255
approved these changes
Jan 16, 2023
|
|
||
| let is_insufficient = value > caller_balance; | ||
|
|
||
| let is_insufficient = (value > caller_balance) && (is_call || is_callcode); |
Contributor
There was a problem hiding this comment.
The corresponding circuit expression only does is_insufficient = value > caller_balance. This is because when not(is_call || is_callcode) then value = 0 so value > caller_balance == 0 > caller_balance == false.
So I believe adding the && (is_call || is_callcode here is redundant. Nevertheless maybe it makes things more clear? This is just an observation, not a request to change anything.
Contributor
|
@lispc do you consider this PR approved? Or would you like to see some changes? |
lispc
approved these changes
Jan 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix two issues: