feat: serde trait for field and group elements

[zhenfeizhang]

serde is quite useful for downstream libraries. would love to have this feature enabled

the user can enable it with feature = derive_serde

[han0110]

LGTM! But I remember the reason to manually implement SerdeObject is to avoid dependency serde, so I think it'd be nice to have flag to enable/disable this.

[CPerezz]

Please, put this behind a serde feature. The derives and the imports as well as the serde dependency.

Users that don't need it should not pay for it in compilation time.

[CPerezz]

I'd create a serde feature and import this under it.

[zhenfeizhang]

cool. added in 5b97d11

[zhenfeizhang]

Don't know why CI failed...

 cargo test --verbose --release --all --features asm

passed on my local machine

[CPerezz]

Don't know why CI failed...

 cargo test --verbose --release --all --features asm

passed on my local machine

No worries. It happens sometimes. Not sure what's the exact issue with the gh-runner TBH.
I triggered it again. Let's hope it works now.

[CPerezz]

LGTM! Thanks for adding the feature!!

[han0110]

Hi @zhenfeizhang is there any specific reason not re-export ff and group by default? I think it'd a little awkward for downstream libraries since all of those relying on halo2curves now need to specify the reexport feature (I think most of them need to import the traits in ff and group).

If no specific concern I'd suggest to make re-export it by default, what do you think?

[zhenfeizhang]

Hi @zhenfeizhang is there any specific reason not re-export ff and group by default? I think it'd a little awkward for downstream libraries since all of those relying on halo2curves now need to specify the reexport feature (I think most of them need to import the traits in ff and group).

If no specific concern I'd suggest to make re-export it by default, what do you think?

Happy to do so. Want to double check @CPerezz before preceeding

The derives and the imports as well as the serde dependency.

Users that don't need it should not pay for it in compilation time.

Is re-export enabled by default okay with you?