Skip to content

Organize serialization#177

Closed
adria0 wants to merge 4 commits into
mainfrom
fix/serialization
Closed

Organize serialization#177
adria0 wants to merge 4 commits into
mainfrom
fix/serialization

Conversation

@adria0

@adria0 adria0 commented Oct 4, 2024

Copy link
Copy Markdown
Contributor

As described in #176, this PR:

@adria0 adria0 linked an issue Oct 4, 2024 that may be closed by this pull request

@guorong009 guorong009 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adria0
I think the current update is good.
But, I think we need more updates, if we aim to organize serialization in this PR.

From this comment, I think we can remove the SerdeObject from this repository.
But, it should be done in the basis of implementing the from/to_mont for curve/field.

Please add more implementations if needed.

cc @davidnevadoc

@adria0

adria0 commented Oct 14, 2024

Copy link
Copy Markdown
Contributor Author

From this comment, I think we can remove the SerdeObject from this repository. But, it should be done in the basis of implementing the from/to_mont for curve/field.

from/to_mont is already implemented for fields. Do you mean implementing them for curves? I do not see the specific use case the implement from/to_mont for curves (as also, AFAIS does not exist the concept of montgomery for curves, only for fields)

@adria0

adria0 commented Nov 13, 2024

Copy link
Copy Markdown
Contributor Author

Superseded by #179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Serialization Documentation failing for 0.7.0 release

2 participants