Configurable instance query#96
Merged
han0110 merged 3 commits intoOct 22, 2022
Merged
Conversation
3 tasks
han0110
force-pushed
the
feature/configurable-instance-query
branch
from
443818d to
669a02a
Compare
han0110
force-pushed
the
feature/configurable-instance-query
branch
from
669a02a to
090c4d7
Compare
jonathanpwang
added a commit
to jonathanpwang/snark-verifier
that referenced
this pull request
Oct 16, 2022
in `halo2_proofs` main. Made modifications so that `plonk-verifier` now works even without "Configurable instance query" privacy-ethereum/halo2#96
kilic
approved these changes
Oct 21, 2022
iquerejeta
added a commit
to input-output-hk/halo2
that referenced
this pull request
May 8, 2024
…parallelize-endoscaling-tests Parallelize endoscaling tests
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to make KZG commitment scheme not to query the instance columns from prover, instead calculate the evaluation directly in verifier side.
Current implementation is adding a
const QUERY_INSTANCE: boolinProverandVerifiertraits, then increate_proofandverify_proofit gets the instance evaluation from transcript or by evaluating respectively.