dev: add name for lookup#29
Merged
ChihChengLiang merged 4 commits intoFeb 16, 2022
Merged
Conversation
Closed
ChihChengLiang
approved these changes
Feb 16, 2022
ChihChengLiang
left a comment
ChihChengLiang
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me! Thank you, @lispc, for the PR. This would make debugging lookup a lot nicer.
|
Should this PR be into main or kzg-rebase ? |
Collaborator
|
@barryWhiteHat Yes, just did one the merge kzg-rebase to main in #32 |
5 tasks
iquerejeta
referenced
this pull request
in input-output-hk/halo2
May 8, 2024
…files Add cost-model goldenfile to eccops benchmark
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the lookup error message only contains the lookup index but no lookup name. So debugging lookup error is very difficult. This PR add a name to lookup, so VerifyFailure::Lookup can contain the lookup name.
Solves #17 and zcash#441