Security hardening & refactor: redaction, safe persistence, CLI/provider/tool cleanup, and tests - #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
utils/redaction.pyand applyredact_sensitive_textwhen persisting or analyzing tool outputs and when saving reports/sessions to disk.tools/base_tool.pyand logging a redacted form (commandnow uses the sanitized string).core/workflow.py,core/memory.py).defusedxml.ElementTree, size limits and rejecting DTD/entities to prevent XML entity and DoS attacks (tools/nmap.py).utils/scope_validator.py).utils/redaction.pytests and other unit test improvements; refactored many CLI command modules for consistent argument handling and minor UX fixes (cli/commands/*).fail_underinpyproject.toml, and constrained dependency bounds for release stability.Testing
pytest(including asyncio tests); all tests passed locally after the changes and new tests were added (notablytests/test_redaction.py) indicating redaction and persistence permissions behave as expected.Codex Task