Security hardening, refactor and robustness fixes across AI providers, tools and CLI - #2
Closed
prithvee07 wants to merge 1 commit into
Closed
Security hardening, refactor and robustness fixes across AI providers, tools and CLI#2prithvee07 wants to merge 1 commit into
prithvee07 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
utils.redaction.redact_sensitive_textand apply redaction to tool outputs and session persistence, and ensureBaseToolnever exposes raw executablecommandwith secrets by logging a sanitizedsafe_commandinstead.0o600for files,0o700for directories) when saving state and reports, and use safe open flags to avoid symlink following.tools/nmap.pynow rejects DTD/entity-containing or oversized XML inputs;ScopeValidatortightens blacklist logic and DNS resolution checks to prevent DNS-rebinding and blocks non-global addresses; many tool parsers and wrappers were made more resilient against malformed output.ai.prompt_templates.__init__, provider implementations updated to import LangChain message classes consistently, and dependency bounds added topyproject.toml.Testing
pytest(updated/added tests includetests/test_redaction.py, enhancements totests/test_memory.py,tests/test_nmap_tool.py,tests/test_base_tool.py, and others) and verified the test run completed successfully.Codex Task