Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tracing): rework capturing and use it for all requests #5049

Draft
wants to merge 35 commits into
base: main
Choose a base branch
from
Draft

fix(tracing): rework capturing and use it for all requests #5049

wants to merge 35 commits into from
+1,533 −51

Conversation

aqrln
Copy link
Member

@aqrln aqrln commented Nov 17, 2024

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 17, 2024 •
edited
Loading

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.036MiB 2.038MiB -1.814KiB
Postgres (gzip) 818.099KiB 818.840KiB -759.000B
Mysql 2.005MiB 2.001MiB 4.500KiB
Mysql (gzip) 805.660KiB 804.595KiB 1.065KiB
Sqlite 1.901MiB 1.900MiB 608.000B
Sqlite (gzip) 764.858KiB 765.015KiB -161.000B

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 19, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #5049 will not alter performance

Comparing rework-tracing (3453dd6) with main (90c6eb3)

Summary

✅ 11 untouched benchmarks

@aqrln
libs/telemetry: use tracing-futures from workspace deps
9a7605b
@aqrln
libs/telemetry: remove obsolete dependency
42a7286
@aqrln
Update tracing and tracing-subscriber
e582ab6
@aqrln
Add capturing::ng module
a232d63
@aqrln
We don't use tide anymore
b0290b7
@aqrln
Add TraceParent and WithContext
3086d14
@aqrln
Add SpanBuilder
93742a6
@aqrln
Implement SpanBuilder and SpanAttributeVisitor
a620b0c
@aqrln
Add Collector trait
2d82c2c
@aqrln
Add tests for layer
2deb276
@aqrln
Fix import
ad40d36
@aqrln
Sort attributes map
87d767a
@aqrln
Style change
f7ea290
@aqrln
Fix redacting span IDs in Options
7c5cf7f
@aqrln
Remove unnecessary qualifier
1cdb4c5
@aqrln
Update snapshot to what's expected
1b40e75
@aqrln
Declare empty field in test
dc9772f
@aqrln
Add test for renamed span
bd5ff0b
@aqrln
Add test_follows_from
b233026
@aqrln
Remove sleep
180e85d
@aqrln
Add on_event
09b53c3
@aqrln
Implement events capturing in subscriber layer
86b8bad
@aqrln
Add span IDs to events
f1503e7
@aqrln
Add some comments
b41eb76
@aqrln
Add ExporterInner
84280d3
@aqrln
Introduce SerializableNonZeroU64
7300b75
@aqrln
Make SerializableNonZeroU64 deserializable
de0e9e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aqrln