Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgres: switch to query_typed api to avoid prepared statement overhead #5032

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tmm1
Copy link
Contributor

@tmm1 tmm1 commented Nov 1, 2024

implements the new query_typed api from sfackler/rust-postgres#1147

this will remove extra round-trips to the database to create prepared statements.

these roundtrips are especially apparent when statement caching is unavailable, such as when using pgbouncer.

statement cache was also ineffective when using traceparent tracing, because sql comments are part of the statement cache key.

follow up to #5027

fixes #5025 #5017

cc @aqrln

@tmm1 tmm1 requested a review from a team as a code owner November 1, 2024 00:49
@tmm1 tmm1 requested review from jkomyno and removed request for a team November 1, 2024 00:49
Copy link

codspeed-hq bot commented Nov 1, 2024

CodSpeed Performance Report

Merging #5032 will not alter performance

Comparing anysphere:rust-postgres-query-typed (db8a787) with main (feda6ce)

Summary

✅ 11 untouched benchmarks

@jkomyno jkomyno requested review from aqrln and removed request for jkomyno November 1, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade rust-postgres and support single-packet queries?
1 participant