feat: include field native type attributes data to DMMF

[pasha-vuiko]

Hi!
This PR exposes schema field native type data to DMMF.

Very long awaited feature for many people and me 🙂

[CLAassistant]

All committers have signed the CLA.

[codspeed-hq]

CodSpeed Performance Report

Merging #5009 will not alter performance

_{Comparing pasha-vuiko:feat/include-field-native-type-data-to-dmmf (f616ccc) with main (29bc8ca)}

Summary

✅ 11 untouched benchmarks

[jkomyno]

Hi @pasha-vuiko, thanks for this PR!
Can we please ask you to fix the clippy tests?

[pasha-vuiko]

Yep, I'll try to fix them today

[pasha-vuiko]

jkomyno I fixed Clippy warnings and DMMF generation related unit tests

[pasha-vuiko]

sweeeet, so now I'm supposed to update 137mb JSON to make the fallen unit tests work?😅

[aqrln]

sweeeet, so now I'm supposed to update 137mb JSON to make the fallen unit tests work?😅

You just need to run the tests with UPDATE_EXPECT=1 env var set

[aqrln]

UPDATE_EXPECT=1 cargo test -p dmmf -F psl/all — something like this

[pasha-vuiko]

@aqrln thank you so much for your suggestion, I pushed the new commit

[aqrln]

Nice, this looks good to me. Would you be willing to update the TypeScript side as well (type definitions + snapshots in tests)?

[pasha-vuiko]

yes, I already created the PR in the Prisma repo
prisma/prisma#25324
Currently it has some type related errors on test run, because it generates JSON files based on old version of prisma-engines (without the DMMF native type exposing) so what should I do next? Is it possible to somehow 'point' the prisma TS part to Rust part from the current PR?

[aqrln]

Is it possible to somehow 'point' the prisma TS part to Rust part from the current PR?

It's a bit convoluted with forks. I created #5045 to release an integration version of the engines that you can use. An automated draft PR updating the engines to this version should appear in the main repo in a bit.

We should probably make the /engines-branch command in client PRs support forked repos, as that is a much better workflow.

[pasha-vuiko]

excuse me, I'm a bit confused, what should I do next to make the tests work with new version prisma-engines locally and in the pipeline?

[aqrln]

You can cherry-pick the commit from prisma/prisma#25653 in the client repo.

Locally you can also set export PRISMA_QUERY_ENGINE_LIBRARY=/absolute/path/to/target/debug/libquery_engine.so and export PRISMA_SCHEMA_ENGINE_BINARY=/.../target/debug/schema-engine instead.