feat: improve type inference for sqlite (typedsql) #4976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WASM Query Engine file Size
|
CodSpeed Performance ReportMerging #4976 will not alter performanceComparing Summary
|
jkomyno
reviewed
Aug 12, 2024
schema-engine/connectors/sql-schema-connector/src/flavour/mysql/connection.rs
Show resolved
Hide resolved
jkomyno
reviewed
Aug 12, 2024
Comment on lines
+320
to
+321
| api.query_raw("SELECT 1=1 as `true`, 1=0 AS `false`;", &[]) | ||
| .assert_single_row(|row| row.assert_int_value("true", 1).assert_int_value("false", 0)); |
There was a problem hiding this comment.
Right, I always forget that SQLite doesn't return booleans
|
Looking at the Wasm Query Engine size table, I see the gzipped size of the packages increased by a few KBs. While this is understandable for SQLite, it can perhaps be avoided for MySQL and PostgreSQL. May you please give it another look in that direction? Thanks! |
jkomyno
reviewed
Aug 12, 2024
Weakky
force-pushed
the
feat/typed-sql-sqlite
branch
from
3794977
to
8ad8a33
Compare
jkomyno
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
closes https://github.com/prisma/team-orm/issues/1249