Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: remove actor system for transactions" #4975

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

SevInf
Copy link
Member

@SevInf SevInf commented Aug 8, 2024

It itdroduced a couple of regressions into client pipeline and currently blocking integration of subsequent commits.
Reverts #4940

@SevInf SevInf requested a review from a team as a code owner August 8, 2024 14:53
@SevInf SevInf requested review from Weakky and removed request for a team August 8, 2024 14:53
Copy link

codspeed-hq bot commented Aug 8, 2024

CodSpeed Performance Report

Merging #4975 will not alter performance

Comparing revert-4940-feat/remove-actors-attempt-2 (0045c50) with main (8c1ddb7)

Summary

✅ 11 untouched benchmarks

Copy link
Contributor

github-actions bot commented Aug 8, 2024

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.061MiB 2.052MiB 9.341KiB
Postgres (gzip) 822.646KiB 817.785KiB 4.862KiB
Mysql 2.030MiB 2.020MiB 9.347KiB
Mysql (gzip) 809.626KiB 804.893KiB 4.734KiB
Sqlite 1.926MiB 1.917MiB 9.041KiB
Sqlite (gzip) 769.290KiB 764.429KiB 4.861KiB

@jkomyno
Copy link
Contributor

jkomyno commented Aug 9, 2024

Merging with two notes:

  • D1 tests are failing because of prisma/prisma
  • "Build Engines / Decide if a release of the engines artifacts is necessary" is failing in the "Debug Pull Request Event" for apparently no valid reason (see Slack). This isn't blocking though

@jkomyno jkomyno merged commit e1242e1 into main Aug 9, 2024
363 of 368 checks passed
@jkomyno jkomyno deleted the revert-4940-feat/remove-actors-attempt-2 branch August 9, 2024 09:04
aqrln pushed a commit that referenced this pull request Sep 21, 2024
aqrln pushed a commit that referenced this pull request Sep 24, 2024
aqrln pushed a commit that referenced this pull request Sep 25, 2024
aqrln pushed a commit that referenced this pull request Sep 26, 2024
aqrln pushed a commit that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants