-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: expose ColumnType
to quaint::ResultSet
#4960
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #4960 will not alter performanceComparing Summary
|
WASM Query Engine file Size
|
Weakky
force-pushed
the
improve/quaint-column-type
branch
from
July 19, 2024 14:19
fac12db
to
9089d54
Compare
Weakky
commented
Jul 19, 2024
Weakky
commented
Jul 19, 2024
Weakky
commented
Jul 22, 2024
Weakky
force-pushed
the
improve/quaint-column-type
branch
from
July 22, 2024 13:24
a3bb63c
to
6cf1799
Compare
Weakky
force-pushed
the
improve/quaint-column-type
branch
from
July 22, 2024 13:26
6cf1799
to
074e622
Compare
SevInf
reviewed
Jul 22, 2024
SevInf
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, LGTM with one small nit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
closes https://github.com/prisma/team-orm/issues/1245
This PR adds a new
types
fields toquaint::ResultSet
. It is a preparatory PR for the TypedSQL initiative. It helps to have a single abstraction that's used both forTypedSQL
andqueryRaw
in general. This ensures we're always in sync between the types sent to the client at compile-time and those sent back at runtime.For Postgres specifically, this PR adds a macro that helps keep the
ColumnType
and the actualValue
we return at runtime in sync.